fix: Restore archived ciphers through the unarchive endpoint - #1565
Open
mvanhorn wants to merge 1 commit into
Open
fix: Restore archived ciphers through the unarchive endpoint#1565mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teach
CipherSyncOpsto compare the server cipher’s archive state with the desired local state during an existing-cipher push. Keyguard 3.0.0 lets a user choose “Restore from archive,” but the item remains archived after synchronization with Vaultwarden 1.37.1 backed by PostgreSQL.Restore an archived cipher without other content changes and verify sync sends the remote ID to
PUT /api/ciphers/unarchive, performs the final GET, and returns a cipher whosearchivedDateis null; Restore an archived cipher while changing another field and verify the normal cipher PUT occurs before the dedicated unarchive request, with the final GET reflecting both changes.Closes #1526